Add new "AMD FSR FG" frame type - #680
Draft
mgharbha wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Michael Gharbharan <Michael.Gharbharan@amd.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AMD FSR Frame Generation as a recognized frame type throughout the provider, trace-consumption, output, and API layers.
Changes:
- Defines and validates the
AMD_FSR_FGframe type. - Propagates classification and display-name support across consumers and clients.
- Adds a metrics test, currently referencing an unavailable abstraction.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Provider/PresentMonProvider.h |
Defines the provider frame type. |
Provider/PresentMonProvider.cpp |
Validates the new value. |
PresentMon/CsvOutput.cpp |
Adds CSV formatting. |
PresentData/PresentMonTraceConsumer.cpp |
Converts and classifies generated frames. |
PresentData/PresentEventEnums.hpp |
Defines the internal frame type. |
PresentData/ETW/Intel_PresentMon.h |
Defines the ETW value. |
PresentData/Debug.cpp |
Adds debug formatting. |
IntelPresentMon/UnitTests/MetricsCore.cpp |
Adds an AMD FSR FG metrics test. |
IntelPresentMon/SampleClient/PacedFramePlayback.cpp |
Adds sample CSV translation. |
IntelPresentMon/PresentMonAPI2Tests/CsvHelper.h |
Adds test CSV conversion. |
IntelPresentMon/PresentMonAPI2/PresentMonAPI.h |
Exposes the public API value. |
IntelPresentMon/Interprocess/source/metadata/EnumFrameType.h |
Adds introspection metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| 23'000, 400, 30'500, | ||
| { { FrameType::Application, 24'000 } }); | ||
|
|
||
| auto idx = DisplayIndexing::Calculate(present, &nextDisplayed); |
mgharbha
marked this pull request as draft
September 1, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an AMD_FSR_FG frame type for frames generated by AMD FSR Frame Generation.